chore(bidi): pointerMove action needs to floor fractional values for x and y position #34191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Jan 2, 2025
This comment has been minimized.
This comment has been minimized.
|
@whimboo Do you plan to update this PR or should we close it? |
Ideally yes, but I'm lacking time at the moment. Could someone from your side assist and finish this patch? I would appreciate. |
yury-s
approved these changes
Feb 7, 2025
…x and y position. For elements that are only 1 pixel in size, rounding can cause the click to occur outside the element’s rect. For example, a 1px div at (8,8) would not be reached if the click is rounded to (9,9).
yury-s
force-pushed
the
bidi-perform-action-move-fractional
branch
from
8af1764 to
c062552
Compare
|
I've pushed rebased version to whimboo:bidi-perform-action-move-fractional |
|
On a closer look, the problem is specific to Firefox implementation of Bidi as Chromium does not throw on fractional coordinates and handles them just fine (as underlying CDP implementation does, I guess). I see that in the spec the coordinates are typed as |
Test results for "tests 1"11 flaky37801 passed, 655 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For elements that are only 1 pixel in size, rounding can cause the click to occur outside the element’s rect.
For example, a 1px div at (8,8) would not be reached if the click is rounded to (9,9).
This will fix the test
page/page-click.spec.ts :: should click the aligned 1x1 div.@yury-s can you please review? Thanks.